gnu: ncurses: Rewrite using gexps.

* gnu/packages/ncurses.scm (ncurses-rollup-patch): New procedure.
(ncurses)[arguments]: Rewrite using gexps.
[native-inputs]: Remove labels and remove "rollup-patch" input.
(ncurses/gpm, ncurses/tinfo): Rewrite using gexps and remove input
label.
This commit is contained in:
Ludovic Courtès 2023-02-25 19:45:56 +01:00
parent ec93f243ff
commit 4895846197
No known key found for this signature in database
GPG key ID: 090B11993D9AEBB5

View file

@ -1,5 +1,5 @@
;;; GNU Guix --- Functional package management for GNU ;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2012, 2013, 2014, 2015, 2017, 2018, 2019 Ludovic Courtès <ludo@gnu.org> ;;; Copyright © 2012, 2013, 2014, 2015, 2017, 2018, 2019, 2023 Ludovic Courtès <ludo@gnu.org>
;;; Copyright © 2014, 2016 Mark H Weaver <mhw@netris.org> ;;; Copyright © 2014, 2016 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2015, 2017 Leo Famulari <leo@famulari.name> ;;; Copyright © 2015, 2017 Leo Famulari <leo@famulari.name>
;;; Copyright © 2016 Nikita <nikita@n0.is> ;;; Copyright © 2016 Nikita <nikita@n0.is>
@ -27,6 +27,7 @@
(define-module (gnu packages ncurses) (define-module (gnu packages ncurses)
#:use-module (gnu packages) #:use-module (gnu packages)
#:use-module (guix licenses) #:use-module (guix licenses)
#:use-module (guix gexp)
#:use-module (guix packages) #:use-module (guix packages)
#:use-module (guix download) #:use-module (guix download)
#:use-module (guix build-system gnu) #:use-module (guix build-system gnu)
@ -37,8 +38,22 @@
#:use-module (gnu packages swig) #:use-module (gnu packages swig)
#:use-module (gnu packages linux) #:use-module (gnu packages linux)
#:use-module (guix utils) #:use-module (guix utils)
#:use-module ((guix memoization) #:select (mlambda))
#:use-module (ice-9 match)) #:use-module (ice-9 match))
(define ncurses-rollup-patch
(mlambda (version)
(origin
(method url-fetch)
(uri (match (string-split (version-major+minor+point version) #\.)
((major minor point)
(string-append "https://invisible-mirror.net/archives"
"/ncurses/" major "." minor "/ncurses-"
major "." minor "-" point "-patch.sh.bz2"))))
(sha256
(base32
"1b6522cvi4066bgh9lp93q8lk93zcjjssvnw1512z447xvazy2y6")))))
(define-public ncurses (define-public ncurses
(package (package
(name "ncurses") (name "ncurses")
@ -56,170 +71,152 @@
"doc")) ;1 MiB of man pages "doc")) ;1 MiB of man pages
(arguments (arguments
(let ((patch-makefile-phase (let ((patch-makefile-phase
'(lambda _ #~(lambda _
(for-each patch-makefile-SHELL (for-each patch-makefile-SHELL
(find-files "." "Makefile.in")))) (find-files "." "Makefile.in"))))
(configure-phase (configure-phase
;; The 'configure' script does not understand '--docdir', so we must ;; The 'configure' script does not understand '--docdir', so we must
;; override that and use '--mandir' instead. ;; override that and use '--mandir' instead.
'(lambda* (#:key build target outputs configure-flags #~(lambda* (#:key build target outputs configure-flags
#:allow-other-keys) #:allow-other-keys)
(let ((out (assoc-ref outputs "out")) (let ((out (assoc-ref outputs "out"))
(doc (assoc-ref outputs "doc"))) (doc (assoc-ref outputs "doc")))
(apply invoke "./configure" (apply invoke "./configure"
(string-append "SHELL=" (which "sh")) (string-append "SHELL=" (which "sh"))
(string-append "--build=" build) (string-append "--build=" build)
(string-append "--prefix=" out) (string-append "--prefix=" out)
(string-append "--mandir=" doc "/share/man") (string-append "--mandir=" doc "/share/man")
(if target (if target
(cons (string-append "--host=" target) (cons (string-append "--host=" target)
configure-flags) configure-flags)
configure-flags))))) configure-flags)))))
(apply-rollup-patch-phase (apply-rollup-patch-phase
;; Ncurses distributes "stable" patchsets to be applied on top ;; Ncurses distributes "stable" patchsets to be applied on top
;; of the release tarball. These are only available as shell ;; of the release tarball. These are only available as shell
;; scripts(!) so we decompress and apply them in a phase. ;; scripts(!) so we decompress and apply them in a phase.
;; See <https://invisible-mirror.net/archives/ncurses/6.1/README>. ;; See <https://invisible-mirror.net/archives/ncurses/6.1/README>.
'(lambda* (#:key inputs native-inputs #:allow-other-keys) #~(lambda* (#:key inputs native-inputs #:allow-other-keys)
(let ((rollup-patch (assoc-ref (or native-inputs inputs) (let ((rollup-patch #$(ncurses-rollup-patch
"rollup-patch"))) (package-version this-package))))
(when rollup-patch (copy-file rollup-patch
(copy-file rollup-patch (string-append (getcwd) "/rollup-patch.sh.bz2"))
(string-append (getcwd) "/rollup-patch.sh.bz2")) (invoke "bzip2" "-d" "rollup-patch.sh.bz2")
(invoke "bzip2" "-d" "rollup-patch.sh.bz2") (invoke "sh" "rollup-patch.sh"))))
(invoke "sh" "rollup-patch.sh")))))
(remove-shebang-phase (remove-shebang-phase
'(lambda _ #~(lambda _
;; To avoid retaining a reference to the bootstrap Bash via the ;; To avoid retaining a reference to the bootstrap Bash via the
;; shebang of the 'ncursesw6-config' script, simply remove that ;; shebang of the 'ncursesw6-config' script, simply remove that
;; shebang: it'll work just as well without it. Likewise, do not ;; shebang: it'll work just as well without it. Likewise, do not
;; retain a reference to the "doc" output. ;; retain a reference to the "doc" output.
(substitute* "misc/ncurses-config.in" (substitute* "misc/ncurses-config.in"
(("#!@SHELL@") (("#!@SHELL@")
"# No shebang here, use /bin/sh!\n") "# No shebang here, use /bin/sh!\n")
(("@SHELL@ \\$0") (("@SHELL@ \\$0")
"$0") "$0")
(("mandir=.*$") (("mandir=.*$")
"mandir=share/man")))) "mandir=share/man"))))
(post-install-phase (post-install-phase
`(lambda* (#:key outputs #:allow-other-keys) #~(lambda* (#:key outputs #:allow-other-keys)
(let ((out (assoc-ref outputs "out"))) (let ((out (assoc-ref outputs "out")))
;; When building a wide-character (Unicode) build, create backward ;; When building a wide-character (Unicode) build, create backward
;; compatibility links from the the "normal" libraries to the ;; compatibility links from the the "normal" libraries to the
;; wide-character ones (e.g. libncurses.so to libncursesw.so). ;; wide-character ones (e.g. libncurses.so to libncursesw.so).
,@(if (target-mingw?) #$@(if (target-mingw?)
'( ;; TODO: create .la files to link to the .dll? '( ;; TODO: create .la files to link to the .dll?
(with-directory-excursion (string-append out "/bin") (with-directory-excursion (string-append out "/bin")
(for-each (for-each
(lambda (lib) (lambda (lib)
(define lib.dll (define lib.dll
(string-append "lib" lib ".dll")) (string-append "lib" lib ".dll"))
(define libw6.dll (define libw6.dll
(string-append "lib" lib "w6.dll")) (string-append "lib" lib "w6.dll"))
(when (file-exists? libw6.dll) (when (file-exists? libw6.dll)
(format #t "creating symlinks for `lib~a'~%" lib) (format #t "creating symlinks for `lib~a'~%" lib)
(symlink libw6.dll lib.dll))) (symlink libw6.dll lib.dll)))
'("curses" "ncurses" "form" "panel" "menu")))) '("curses" "ncurses" "form" "panel" "menu"))))
'()) #~())
(with-directory-excursion (string-append out "/lib") (with-directory-excursion (string-append out "/lib")
(for-each (lambda (lib) (for-each (lambda (lib)
(define libw.a (define libw.a
(string-append "lib" lib "w.a")) (string-append "lib" lib "w.a"))
(define lib.a (define lib.a
(string-append "lib" lib ".a")) (string-append "lib" lib ".a"))
,@(if (not (target-mingw?)) #$@(if (not (target-mingw?))
'((define libw.so.x #~((define libw.so.x
(string-append "lib" lib "w.so.6")) (string-append "lib" lib "w.so.6"))
(define lib.so.x (define lib.so.x
(string-append "lib" lib ".so.6")) (string-append "lib" lib ".so.6"))
(define lib.so (define lib.so
(string-append "lib" lib ".so")) (string-append "lib" lib ".so"))
(define packagew.pc (define packagew.pc
(string-append lib "w.pc")) (string-append lib "w.pc"))
(define package.pc (define package.pc
(string-append lib ".pc"))) (string-append lib ".pc")))
'()) #~())
(when (file-exists? libw.a) (when (file-exists? libw.a)
(format #t "creating symlinks for `lib~a'~%" lib) (format #t "creating symlinks for `lib~a'~%" lib)
(symlink libw.a lib.a) (symlink libw.a lib.a)
,@(if (not (target-mingw?)) #$@(if (not (target-mingw?))
'((symlink libw.so.x lib.so.x) '((symlink libw.so.x lib.so.x)
(false-if-exception (delete-file lib.so)) (false-if-exception (delete-file lib.so))
(call-with-output-file lib.so (call-with-output-file lib.so
(lambda (p) (lambda (p)
(format p "INPUT (-l~aw)~%" lib))) (format p "INPUT (-l~aw)~%" lib)))
(with-directory-excursion "pkgconfig" (with-directory-excursion "pkgconfig"
(format #t "creating symlink for `~a'~%" (format #t "creating symlink for `~a'~%"
package.pc) package.pc)
(when (file-exists? packagew.pc) (when (file-exists? packagew.pc)
(symlink packagew.pc package.pc)))) (symlink packagew.pc package.pc))))
'()))) #~())))
'("curses" "ncurses" "form" "panel" "menu"))))))) '("curses" "ncurses" "form" "panel" "menu")))))))
`(#:configure-flags (list #:configure-flags
,(cons* #~`("--with-shared" "--without-debug" "--enable-widec"
'quasiquote
`(("--with-shared" "--without-debug" "--enable-widec"
"--enable-pc-files" "--enable-pc-files"
,(list 'unquote '(string-append "--with-pkg-config-libdir=" ,(string-append "--with-pkg-config-libdir="
(assoc-ref %outputs "out") #$output "/lib/pkgconfig")
"/lib/pkgconfig"))
;; By default headers land in an `ncursesw' subdir, which is not ;; By default headers land in an `ncursesw' subdir, which is not
;; what users expect. ;; what users expect.
,(list 'unquote '(string-append "--includedir=" (assoc-ref %outputs "out") ,(string-append "--includedir=" #$output "/include")
"/include")) "--enable-overwrite" ;really honor --includedir
"--enable-overwrite" ;really honor --includedir
;; Make sure programs like 'tic', 'reset', and 'clear' have a ;; Make sure programs like 'tic', 'reset', and 'clear' have a
;; correct RUNPATH. ;; correct RUNPATH.
,(list 'unquote '(string-append "LDFLAGS=-Wl,-rpath=" (assoc-ref %outputs "out") ,(string-append "LDFLAGS=-Wl,-rpath=" #$output "/lib")
"/lib"))
;; Starting from ncurses 6.1, "make install" runs "install -s" ;; Starting from ncurses 6.1, "make install" runs "install -s"
;; by default, which doesn't work for cross-compiled binaries ;; by default, which doesn't work for cross-compiled binaries
;; because it invokes 'strip' instead of 'TRIPLET-strip'. Work ;; because it invokes 'strip' instead of 'TRIPLET-strip'. Work
;; around this. ;; around this.
,@(if (%current-target-system) '("--disable-stripping") '()) #$@(if (%current-target-system) #~("--disable-stripping") #~())
;; Do not assume a default search path in ld, even if it is only to ;; Do not assume a default search path in ld, even if it is only to
;; filter it out in ncurses-config. Mainly because otherwise it ends ;; filter it out in ncurses-config. Mainly because otherwise it ends
;; up using the libdir from binutils, which makes little sense and ;; up using the libdir from binutils, which makes little sense and
;; causes an unnecessary runtime dependency. ;; causes an unnecessary runtime dependency.
"cf_cv_ld_searchpath=/no-ld-searchpath" "cf_cv_ld_searchpath=/no-ld-searchpath"
;; MinGW: Use term-driver created for the MinGW port. ;; MinGW: Use term-driver created for the MinGW port.
,@(if (target-mingw?) '("--enable-term-driver") '())))) #$@(if (target-mingw?) #~("--enable-term-driver") #~()))
#:tests? #f ; no "check" target #:tests? #f ; no "check" target
#:phases (modify-phases %standard-phases #:phases #~(modify-phases %standard-phases
(add-after 'unpack 'apply-rollup-patch (add-after 'unpack 'apply-rollup-patch
,apply-rollup-patch-phase) #$apply-rollup-patch-phase)
(replace 'configure ,configure-phase) (replace 'configure #$configure-phase)
(add-after 'install 'post-install (add-after 'install 'post-install
,post-install-phase) #$post-install-phase)
(add-before 'configure 'patch-makefile-SHELL (add-before 'configure 'patch-makefile-SHELL
,patch-makefile-phase) #$patch-makefile-phase)
(add-before 'patch-source-shebangs 'remove-unneeded-shebang (add-before 'patch-source-shebangs 'remove-unneeded-shebang
,remove-shebang-phase))))) #$remove-shebang-phase)))))
(native-inputs (native-inputs
`(,@(if (%current-target-system) (if (%current-target-system)
`(("self" ,this-package)) ;for `tic' (list pkg-config this-package) ;for 'tic'
'()) (list pkg-config)))
("rollup-patch"
,(origin
(method url-fetch)
(uri (match (string-split (version-major+minor+point version) #\.)
((major minor point)
(string-append "https://invisible-mirror.net/archives"
"/ncurses/" major "." minor "/ncurses-"
major "." minor "-" point "-patch.sh.bz2"))))
(sha256
(base32
"1b6522cvi4066bgh9lp93q8lk93zcjjssvnw1512z447xvazy2y6"))))
("pkg-config" ,pkg-config)))
(native-search-paths (native-search-paths
(list (search-path-specification (list (search-path-specification
(variable "TERMINFO_DIRS") (variable "TERMINFO_DIRS")
@ -240,12 +237,11 @@ ncursesw library provides wide character support.")
(arguments (arguments
(substitute-keyword-arguments (package-arguments ncurses) (substitute-keyword-arguments (package-arguments ncurses)
((#:configure-flags cf) ((#:configure-flags cf)
`(cons (string-append "--with-gpm=" #~(cons (string-append "--with-gpm="
(assoc-ref %build-inputs "gpm") #$(this-package-input "gpm")
"/lib/libgpm.so.2") "/lib/libgpm.so.2")
,cf)))) #$cf))))
(inputs (inputs (list gpm))))
`(("gpm" ,gpm)))))
;; Needed by u-boot 2022.04+ ;; Needed by u-boot 2022.04+
;; Consider merging into ncurses for next core-updates cycle. ;; Consider merging into ncurses for next core-updates cycle.
@ -255,8 +251,7 @@ ncursesw library provides wide character support.")
(arguments (arguments
(substitute-keyword-arguments (package-arguments ncurses) (substitute-keyword-arguments (package-arguments ncurses)
((#:configure-flags cf) ((#:configure-flags cf)
`(cons "--with-termlib=tinfo" #~(cons "--with-termlib=tinfo" #$cf))))))
,cf))))))
(define-public dialog (define-public dialog
(package (package