amaharaneko/guix-mirrors
1
1
Fork 0
mirror of https://codeberg.org/guix/guix.git synced 2025-10-02 02:15:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

lint: Add 'input-labels' checker.

Browse source 
* guix/lint.scm (check-input-labels): New procedure.
(%local-checkers): Add 'input-labels' checker.
* tests/lint.scm ("input labels: no warnings")
("input labels: one warning"): New tests.
* doc/guix.texi (Invoking guix lint): Mention it.
This commit is contained in:
Ludovic Courtès 2021-05-20 16:17:00 +02:00
parent 8524349f78
commit b7f1b4c1d0
No known key found for this signature in database
GPG key ID: 090B11993D9AEBB5
3 changed files with 56 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

36
guix/lint.scm
View file

@ -79,6 +79,7 @@
#:export (check-description-style
check-inputs-should-be-native
check-inputs-should-not-be-an-input-at-all
check-input-labels
check-patch-file-names
check-patch-headers
check-synopsis-style
@ -416,6 +417,37 @@ of a package, and INPUT-NAMES, a list of package specifications such as
(package-input-intersection (package-direct-inputs package)
input-names))))
(define (check-input-labels package)
"Emit a warning for labels that differ from the corresponding package name."
(define (check input-kind package-inputs)
(define (warning label name)
(make-warning package
(G_ "label '~a' does not match package name '~a'")
(list label name)
#:field input-kind))
(append-map (match-lambda
(((? string? label) (? package? dependency))
(if (string=? label (package-name dependency))
'()
(list (warning label (package-name dependency)))))
(((? string? label) (? package? dependency) output)
(let ((expected (string-append (package-name dependency)
":" output)))
(if (string=? label expected)
'()
(list (warning label expected)))))
(_
'()))
(package-inputs package)))
(append-map (match-lambda
((kind proc)
(check kind proc)))
`((native-inputs ,package-native-inputs)
(inputs ,package-inputs)
(propagated-inputs ,package-propagated-inputs))))
(define (package-name-regexp package)
"Return a regexp that matches PACKAGE's name as a word at the beginning of a
line."
@ -1583,6 +1615,10 @@ them for PACKAGE."
(name 'inputs-should-not-be-input)
(description "Identify inputs that shouldn't be inputs at all")
(check check-inputs-should-not-be-an-input-at-all))
(lint-checker
(name 'input-labels)
(description "Identify input labels that do not match package names")
(check check-input-labels))
(lint-checker
(name 'license)
;; TRANSLATORS: <license> is the name of a data type and must not be