From dbbef3d57f4f6acd2f9c51c5f9fda97e18fa618c Mon Sep 17 00:00:00 2001
From: 45mg <45mg.writes@gmail.com>
Date: Wed, 25 Dec 2024 12:14:23 -0500
Subject: [PATCH] services: syslog: fix configuration file argument
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* gnu/services/base.scm (syslog-shepherd-service): Separate incorrectly
combined arguments which resulted in an argument like "-f
/etc/syslog.conf" being passed to syslogd, leading it to ignore the
argument and execute without a configuration file. Effects of this
included no log files being written, though the Shepherd service ran
successfully.

Ref: https://issues.guix.gnu.org/70677#4-lineno7
Change-Id: I3dbe00eabd4a10804e554c12e1466483c0b185b7
Signed-off-by: Ludovic Courtès <ludo@gnu.org>
---
 gnu/services/base.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index fc604f029a8..75ce4e8fe57 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -1679,7 +1679,7 @@ reload its settings file.")))
    (start #~(make-forkexec-constructor
              (list #$(syslog-configuration-syslogd config)
                    ;; the -f option here is compatible with rsyslog
-                   #$(string-append "-f " syslog.conf)
+                   "-f" #$syslog.conf
                    #$@(syslog-configuration-extra-options config))
              #:file-creation-mask #o137
              #:pid-file "/var/run/syslog.pid"))