gnu: php: Improve style.

* gnu/packages/php.scm (php) [arguments]: Use gexps.
[native-inputs, inputs]: Drop labels.

Change-Id: I6244b131bfeb3583bd77ca28dd0f8ab93ff8dade
This commit is contained in:
Maxim Cournoyer 2025-09-30 09:12:53 +09:00
parent 732606d654
commit e6b0acff41
No known key found for this signature in database
GPG key ID: 1260E46482E63562

View file

@ -4,7 +4,7 @@
;;; Copyright © 2018, 2020, 2021 Tobias Geerinckx-Rice <me@tobias.gr>
;;; Copyright © 2018 Ricardo Wurmus <rekado@elephly.net>
;;; Copyright © 2019 Oleg Pykhalov <go.wigust@gmail.com>
;;; Copyright © 2020 Maxim Cournoyer <maxim@guixotic.coop>
;;; Copyright © 2020, 2025 Maxim Cournoyer <maxim@guixotic.coop>
;;; Copyright © 2021, 2023 Efraim Flashner <efraim@flashner.co.il>
;;; Copyright © 2023 Timo Wilken <guix@twilken.net>
;;;
@ -55,6 +55,7 @@
#:use-module (gnu packages xorg)
#:use-module (guix packages)
#:use-module (guix download)
#:use-module (guix gexp)
#:use-module (guix build-system gnu)
#:use-module (guix utils)
#:use-module ((guix licenses) #:prefix license:))
@ -64,36 +65,36 @@
(name "php")
(version "8.3.13")
(home-page "https://www.php.net/")
(source (origin
(source
(origin
(method url-fetch)
(uri (string-append home-page "distributions/"
"php-" version ".tar.xz"))
(uri (string-append home-page "distributions/" "php-" version ".tar.xz"))
(sha256
(base32
"061hhx0f6m7q0jajxym72c9a4v4nqixk5mizwm7i42d2riwbkbc9"))
(base32 "061hhx0f6m7q0jajxym72c9a4v4nqixk5mizwm7i42d2riwbkbc9"))
(modules '((guix build utils)))
(snippet
'(with-directory-excursion "ext"
(for-each delete-file-recursively
;; Some of the bundled libraries have no proper upstream.
;; Ideally we'd extract these out as separate packages:
;;"mbstring/libmbfl"
;;"date/lib"
;;"bcmath/libbcmath"
;;"fileinfo/libmagic" ; a patched version of libmagic
'("gd/libgd"
"pcre/pcre2lib"))))))
;; "mbstring/libmbfl"
;; "date/lib"
;; "bcmath/libbcmath"
;; "fileinfo/libmagic" ; a patched version of libmagic
'("gd/libgd" "pcre/pcre2lib"))))))
(build-system gnu-build-system)
(arguments
`(#:configure-flags
(let-syntax ((with (syntax-rules ()
(list
#:configure-flags
#~(let-syntax ((with (syntax-rules ()
((_ option input)
(string-append option "="
(string-append
option "="
(assoc-ref %build-inputs input))))))
(list (with "--with-bz2" "bzip2")
(with "--with-curl" "curl")
(with "--with-gdbm" "gdbm")
(with "--with-gettext" "libc") ; libintl.h
(with "--with-gettext" "libc") ;libintl.h
(with "--with-gmp" "gmp")
(with "--with-ldap" "openldap")
(with "--with-ldap-sasl" "cyrus-sasl")
@ -106,7 +107,7 @@
(with "--with-readline" "readline")
(with "--with-sodium" "libsodium")
(with "--with-sqlite3" "sqlite")
(with "--with-tidy" "tidy")
(with "--with-tidy" "tidy-html")
(with "--with-xsl" "libxslt")
(with "--with-zlib-dir" "zlib")
;; We could add "--with-snmp", but it requires netsnmp that
@ -116,11 +117,11 @@
"--with-external-gd"
"--with-iconv"
"--with-openssl"
"--with-mysqli" ; Required for, e.g. wordpress
"--with-mysqli" ;Required for, e.g. wordpress
"--with-pdo-mysql"
"--with-zip"
"--with-zlib"
"--enable-bcmath" ; Required for, e.g. Zabbix frontend
"--enable-bcmath" ;Required for, e.g. Zabbix frontend
"--enable-calendar"
"--enable-dba=shared"
"--enable-exif"
@ -133,28 +134,33 @@
"--enable-mbstring"
"--enable-pcntl"
"--enable-sockets"
"--enable-sysvsem" ; Required for, e.g. Nextcloud
"--enable-embed" ; Required for embed SAPI
"--enable-sysvsem" ;Required for, e.g. Nextcloud
"--enable-embed" ;Required for embed SAPI
"--enable-zts"
"--disable-zend-signals"
"--enable-zend-max-execution-timers"))
#:phases
(modify-phases %standard-phases
#~(modify-phases %standard-phases
(add-after 'unpack 'do-not-record-build-flags
(lambda _
;; Prevent configure flags from being stored and causing
;; unnecessary runtime dependencies.
(substitute* "scripts/php-config.in"
(("@CONFIGURE_OPTIONS@") "")
(("@PHP_LDFLAGS@") ""))
(("@CONFIGURE_OPTIONS@")
"")
(("@PHP_LDFLAGS@")
""))
;; This file has ISO-8859-1 encoding.
(with-fluids ((%default-port-encoding "ISO-8859-1"))
(substitute* "main/build-defs.h.in"
(("@CONFIGURE_COMMAND@") "(omitted)")))))
(("@CONFIGURE_COMMAND@")
"(omitted)")))))
(add-before 'build 'patch-/bin/sh
(lambda _
(substitute* '("run-tests.php" "ext/standard/proc_open.c")
(("/bin/sh") (which "sh")))))
(substitute* '("run-tests.php"
"ext/standard/proc_open.c")
(("/bin/sh")
(which "sh")))))
(add-before 'check 'prepare-tests
(lambda _
;; Some of these files have ISO-8859-1 encoding, whereas others
@ -164,26 +170,32 @@
"ext/mbstring/tests/mb_send_mail04.phpt"
"ext/mbstring/tests/mb_send_mail05.phpt"
"ext/mbstring/tests/mb_send_mail06.phpt")
(("/bin/cat") (which "cat"))))
(("/bin/cat")
(which "cat"))))
(substitute* '("ext/mbstring/tests/mb_send_mail01.phpt"
"ext/mbstring/tests/mb_send_mail03.phpt"
"ext/mbstring/tests/bug52681.phpt"
"ext/standard/tests/general_functions/bug34794.phpt"
"ext/standard/tests/general_functions/bug44667.phpt"
"ext/standard/tests/general_functions/proc_open.phpt")
(("/bin/cat") (which "cat")))
(("/bin/cat")
(which "cat")))
;; The encoding of this file is not recognized, so we simply drop it.
(delete-file "ext/mbstring/tests/mb_send_mail07.phpt")
(substitute* "ext/standard/tests/streams/bug60602.phpt"
(("'ls'") (string-append "'" (which "ls") "'")))
(("'ls'")
(string-append "'"
(which "ls") "'")))
;; Drop tests known to fail on different architectures:
(for-each delete-file
,(cond
(for-each
delete-file
#$(cond
((target-arm32?)
`(list "ext/calendar/tests/unixtojd_error1.phpt"
'(list
"ext/calendar/tests/unixtojd_error1.phpt"
"ext/opcache/tests/preload_006.phpt"
"ext/opcache/tests/preload_011.phpt"
;; arm can be a lot slower, so a time-related test fails
@ -201,13 +213,13 @@
"sapi/cli/tests/cli_process_title_unix.phpt"
"Zend/tests/concat_003.phpt"))
((target-x86-32?)
`(list "ext/dba/tests/dba_gdbm.phpt"))
'(list "ext/dba/tests/dba_gdbm.phpt"))
((target-ppc32?)
`(list "sapi/phpdbg/tests/watch_001.phpt"
'(list "sapi/phpdbg/tests/watch_001.phpt"
"sapi/phpdbg/tests/watch_003.phpt"
"sapi/phpdbg/tests/watch_004.phpt"))
((target-ppc64le?)
`(list
'(list
;; phpdbg watchpoints don't work.
;; Bug tracked upstream at:
;; https://bugs.php.net/bug.php?id=81408
@ -216,13 +228,14 @@
"sapi/phpdbg/tests/watch_004.phpt"
"sapi/phpdbg/tests/watch_005.phpt"
"sapi/phpdbg/tests/watch_006.phpt"))
(else `'())))
(else ''())))
;; Drop tests that are known to fail.
(for-each delete-file
'("ext/posix/tests/posix_getgrgid.phpt" ; Requires /etc/group.
"ext/posix/tests/posix_getgrnam_basic.phpt" ; Requires /etc/group.
"ext/sockets/tests/bug63000.phpt" ; Fails to detect OS.
(for-each
delete-file
'("ext/posix/tests/posix_getgrgid.phpt" ;Requires /etc/group.
"ext/posix/tests/posix_getgrnam_basic.phpt" ;Requires /etc/group.
"ext/sockets/tests/bug63000.phpt" ;Fails to detect OS.
;; These need exotic locales.
"ext/standard/tests/strings/setlocale_basic1.phpt"
"ext/standard/tests/strings/setlocale_basic2.phpt"
@ -313,51 +326,50 @@
(setenv "SKIP_IO_CAPTURE_TESTS" "1"))))
#:test-target "test"))
(inputs
`(("aspell" ,aspell)
("bzip2" ,bzip2)
("curl" ,curl)
("cyrus-sasl" ,cyrus-sasl)
("freetype" ,freetype)
("fontconfig" ,fontconfig)
("libjpeg-turbo" ,libjpeg-turbo)
("libpng" ,libpng)
("gd" ,gd)
("gdbm" ,gdbm)
("gmp" ,gmp)
("gnutls" ,gnutls)
("icu4c" ,icu4c)
("libgcrypt" ,libgcrypt)
("libpng" ,libpng)
("libsodium" ,libsodium)
("libxml2" ,libxml2)
("libxslt" ,libxslt)
("libx11" ,libx11)
("libzip" ,libzip)
("oniguruma" ,oniguruma)
("openldap" ,openldap)
("openssl" ,openssl)
("pcre" ,pcre2)
("postgresql" ,postgresql)
("readline" ,readline)
("sqlite" ,sqlite)
("tidy" ,tidy-html)
("zlib" ,zlib)))
(list aspell
bzip2
curl
cyrus-sasl
fontconfig
freetype
gd
gdbm
gmp
gnutls
icu4c
libgcrypt
libjpeg-turbo
libpng
libpng
libsodium
libx11
libxml2
libxslt
libzip
oniguruma
openldap
openssl
pcre2
postgresql
readline
sqlite
tidy-html
zlib))
(native-inputs
`(("pkg-config" ,pkg-config)
("bison" ,bison)
("gettext" ,gettext-minimal)
("procps" ,procps))) ; for tests
(list bison
gettext-minimal
pkg-config
procps)) ;for tests
(synopsis "PHP programming language")
(description
"PHP (PHP Hypertext Processor) is a server-side (CGI) scripting
language designed primarily for web development but is also used as
a general-purpose programming language. PHP code may be embedded into
HTML code, or it can be used in combination with various web template
systems, web content management systems and web frameworks." )
(license (list
(license:non-copyleft "file://LICENSE") ; The PHP license.
(license:non-copyleft "file://Zend/LICENSE") ; The Zend license.
license:lgpl2.1 ; ext/mbstring/libmbfl
license:lgpl2.1+ ; ext/bcmath/libbcmath
license:bsd-2 ; ext/fileinfo/libmagic
systems, web content management systems and web frameworks.")
(license (list (license:non-copyleft "file://LICENSE") ;The PHP license.
(license:non-copyleft "file://Zend/LICENSE") ;The Zend license.
license:lgpl2.1 ;ext/mbstring/libmbfl
license:lgpl2.1+ ;ext/bcmath/libbcmath
license:bsd-2 ;ext/fileinfo/libmagic
license:expat)))) ; ext/date/lib