From 6de14570d6f357e1e6cbd3f83336e8bc31cba873 Mon Sep 17 00:00:00 2001 From: Belleve Date: Thu, 12 Sep 2024 19:37:32 -1000 Subject: [PATCH] Fix build break (stack overflow) for no-cv-ss building (#2500) --- .github/workflows/pr-build-validation.yml | 2 +- build-plans.toml | 7 +++++++ packages/glyph/src/glyph.mjs | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-build-validation.yml b/.github/workflows/pr-build-validation.yml index 5474c726d..b069ee35e 100644 --- a/.github/workflows/pr-build-validation.yml +++ b/.github/workflows/pr-build-validation.yml @@ -10,7 +10,7 @@ jobs: strategy: matrix: - fontName: ["Iosevka", "IosevkaSlab", "IosevkaAile", "IosevkaEtoile"] + fontName: ["Iosevka", "IosevkaSlab", "IosevkaAile", "IosevkaEtoile", "IosevkaNoVarTest"] steps: # Checkout repository into `iosevka` sub directory diff --git a/build-plans.toml b/build-plans.toml index 9d4e6b699..f04ce4ba3 100644 --- a/build-plans.toml +++ b/build-plans.toml @@ -875,6 +875,13 @@ shape = 700 menu = 700 css = 700 +[buildPlans.IosevkaNoVarTest] +family = "IosevkaNoVarTest" +spacing = "normal" +serifs = "sans" +noCvSs = true +exportGlyphNames = false + ################################################################################################### # Collect plans diff --git a/packages/glyph/src/glyph.mjs b/packages/glyph/src/glyph.mjs index e80fcea9e..12730021b 100644 --- a/packages/glyph/src/glyph.mjs +++ b/packages/glyph/src/glyph.mjs @@ -145,7 +145,7 @@ export class Glyph { tryBecomeMirrorOf(dst, rankSet) { if (rankSet.has(this) || rankSet.has(dst)) return; - if (dst.hasDependency(this)) return; + if (this === dst || dst.hasDependency(this)) return; const csThis = Geom.hashGeometry(this.geometry); const csDst = Geom.hashGeometry(dst.geometry); if (csThis && csDst && csThis === csDst) {